Exit JVM when OOM #15538
Merged
Exit JVM when OOM #15538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_ExitOnOutOfMemoryError
branch
from
b901c4d
to
acd4152
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15538 +/- ##
=========================================
Coverage 38.15% 38.15%
- Complexity 4707 4708 +1
=========================================
Files 1304 1304
Lines 44828 44828
Branches 4807 4807
=========================================
+ Hits 17105 17106 +1
Misses 25870 25870
+ Partials 1853 1852 -1 ☔ View full report in Codecov by Sentry. |
|
SbloodyS
approved these changes
Jan 31, 2024
zhongjiajie
pushed a commit
that referenced
this pull request
Feb 6, 2024
(cherry picked from commit 25810a8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Avoid JVM doesn't exit when OOM occur. This may cause some problem, e.g. the Server cannot work but still in registry and the server crash alert doesn't send.
Brief change log
Add
-XX:+ExitOnOutOfMemoryErrorin jvm_args_env.sh, this should work on jvm version > 8.Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md